Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logically bound images #950

Closed

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Nov 21, 2024

This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html

Jira: https://issues.redhat.com/browse/OSPRH-11609

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshephar
Once this PR has been reviewed and has the lgtm label, please assign karelyatin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar bshephar force-pushed the logically-bound-images branch 2 times, most recently from 3a2810d to 18d3da9 Compare November 27, 2024 03:11
This change adds logically bound images for use with bootc.
This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html

Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar force-pushed the logically-bound-images branch from 18d3da9 to 00650e7 Compare November 27, 2024 03:54
runAsUser: 42405
seLinuxOptions:
type: ceilometer_polling_t
volumeMounts:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some method of handling TLS mount requirements. It could be a matter of copying this as a base and using Ansible to add the requirements, then write the output to /etc.

Or, we could use a OpenShift build. Render a Containerfile that inherits from our base EDPM image, Go template this file into a ConfigMap with all of the requirements based on the cloud we're deploying too. Then bootc switch to that image on the EDPM nodes during the deployment.

value: COPY_ALWAYS
- name: OS_ENDPOINT_TYPE
value: internal
image: quay.io/podified-antelope-centos9/openstack-ceilometer-compute:current-podified
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be dynamically configurable

name: etc-localtime-host-9
readOnly: true
hostNetwork: true
hostname: edpm-compute-0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be dynamically configurable

@steveb
Copy link
Contributor

steveb commented Nov 27, 2024

Can this be moved to edpm-image-builder/bootc?

@bshephar
Copy link
Contributor Author

Can this be moved to edpm-image-builder/bootc?

It can indeed.

@bshephar
Copy link
Contributor Author

@bshephar bshephar closed this Nov 27, 2024
@bshephar bshephar deleted the logically-bound-images branch November 27, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants